Repository navigation
Detect damaged or partially updated installations on startup - #1067
Merged
Merged
Conversation
manuelmayer-dev
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1059. Repair from the notice is tracked in #1066.
Summary
Every signed package now carries a signed manifest of the files it installs, and the bootstrapper checks the installation against it on startup. Missing or mismatched files are logged and shown as a notice with the download page and the troubleshooting guide, also in the error window when the host no longer starts.
Testing
Full solution build and test suites pass, except the Plugin CLI build test that fails on this machine on main too. Bootstrapper, CI script, desktop UI and localization tests pass. Verified with a locally built release app: intact, cached restart, missing and modified files and a missing host binary all behave as intended. The packaging steps in build.yml only run in a manual build, which should be run once before release.
Checklist