Repository navigation
Let the Web Client choose the icon resolution - #1085
Merged
Merged
Conversation
manuelmayer-dev
added
feature
…esolution # Conflicts: # ui/web-client/src/settings/client-settings.ts # ui/web-client/src/shell.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by the maintainer (no issue).
Summary
The Web Client settings gain Icon resolution: Automatic, 128, 256 or 512 px. Automatic picks the size per widget from how large the icon is drawn and shows the size in use; the host serves icon resources at the requested size through an optional size parameter, and clients without it keep getting 256 px.
Testing
Full solution build and test suites pass, plus runtime and Web Client specs (including legacy and ES5 checks). Verified in a browser against a running host: a phone-sized deck loads 128 px icons, a larger one 256 px, a fixed 512 px applies without reload, and resizing never steps an icon down.
Notes
The icon prefetch still warms only the host side: folder data carries no resource hash, so it cannot hit the exact URL the deck loads (unchanged from before).
Checklist