Repository navigation
Fix duplicate font styles for symlinked fonts on Linux - #1099
Merged
Merged
Conversation
manuelmayer-dev
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1095
Summary
On Linux every symlink to a variable font was listed as its own style, so Ubuntu showed seven Regular and five Italic entries. The font catalog now lists one entry per identical font, and a stored id of a hidden duplicate is rewritten to the listed one when the profile loads.
Testing
Full solution build and test suites pass, with new tests for the catalog and the stored-id rewrite. Checked the real catalog in a Linux arm64 container with a variable font plus symlinks: six entries became one. Not checked: the reporter's actual Ubuntu files, the dropdown on a Linux desktop.
Notes
The first profile load with a saved font now also builds the font catalog at startup.
Checklist