Repository navigation
Add a Label Box Color setting to Action Buttons - #1196
Merged
Merged
Conversation
manuelmayer-dev
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #907
Summary
The Action Button has a new Label Box Color setting under Label Color. When set, the label is drawn on a rounded box of that colour that hugs the text, so it stays readable over an icon or background image. It can be set per state or for the whole button, and unset keeps today's look. Hardware device surfaces and plugin appearance actions do not carry the new setting yet.
Testing
Full solution build with warnings as errors and all test suites pass except the Plugin.Cli build test, which also fails locally on main. New tests cover the data cascade, the view tree and the editor. Checked in the desktop UI against a running host: an unset label measures identically to before, the box hugs the text for left and bottom placement, a long label stays inside the tile, and resetting removes the box. The web client and Companion App were not checked.
Checklist