Repository navigation
Stop the installer treating non-lock file errors as locks - #1201
Merged
manuelmayer-dev merged 1 commit intoOct 5, 2026
Merged
Conversation
manuelmayer-dev
added
bug
manuelmayer-dev
deleted the
fix/installer-host-lock-probe-false-positive
branch
October 5, 2026 05:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on Discord (no issue)
Summary
The Windows installer reported "still in use by another process" for any file it could not open for writing, such as a read-only file. It now counts only sharing and lock violations (and access denied on writable files) as locks, names the Win32 error in the dialog, and no longer ships the .gitkeep placeholder.
Testing
cargo test --test installer_config passes. The NSIS code and the Windows installer harness (new scenarios ReadOnlyFileIsNotALock and error=32 on a held file) were not run locally, only in CI. The reporter's actual cause is unproven: if a scanner holds the files with a sharing violation, the dialog will now say error 32.
Checklist