Repository navigation
Let Action Buttons turn off the label shadow and outline labels - #1213
Merged
Merged
Conversation
manuelmayer-dev
added
feature
…-label-styling-1025 # Conflicts: # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.css.gz # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.js.gz
…-label-styling-1025 # Conflicts: # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.js.gz
…-label-styling-1025 # Conflicts: # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.js.gz
…-label-styling-1025 # Conflicts: # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.js.gz
…ure/action-button-label-styling-1025 # Conflicts: # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.css.gz # sdk/src/MacroDeck.Plugin.Cli/Rendering/Assets/preview-renderer.js.gz
manuelmayer-dev
removed
the
area:sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1025
Summary
Action Buttons can turn off the label shadow and give the label a smooth outline and a label box border, each with colour and width and overridable per state. ui.text gains shadow, strokeColor and strokeWidth, which older readers ignore; the Companion app needs a follow-up.
Testing
Full solution build and tests pass (except the locally known Plugin CLI build test and an audio timing test that passes alone), plus runtime, web client incl. legacy audit and desktop UI render specs. Verified manually in the desktop UI on a running host. Web client and old floor devices not checked visually.
Plugin SDK / API compatibility
Checklist