Repository navigation
Let users name their own icon appearances - #1277
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1197
Summary
An icon can now carry appearances the user names, such as Outlined or Red, next to light, dark, static and animated. They are never picked automatically, and can be chosen in the icon dialog, the editor and the Set Icon Appearance action.
Testing
Full solution build and test suites pass, except the Plugin CLI build test that fails locally on main too. Verified manually in the desktop UI against a running host. Store-side download of single variations is not part of this change.
Plugin SDK / API compatibility
Only a doc comment in the SDK changed. The Set Icon Appearance parameter becomes a dynamic choice with its old options kept as fallback, noted in the compatibility table.
[Obsolete]and[MacroDeckDeprecated], is in the deprecation registry, and still worksChecklist