Repository navigation
Let users mute audio devices by setting their mute variables - #1296
Merged
Merged
Conversation
manuelmayer-dev
added
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mute variables of the default output and input and of every audio device can now be set, so true mutes the device and false unmutes it. The user guide describes how to set them.
Testing
Full solution build and test suites pass, apart from one Plugin CLI test that also fails locally on main. New unit tests cover default and per-device mute writes, invalid values and unavailable devices. On a running host, setting a device mute variable to true and back to false through the API muted and unmuted the real device on macOS.
Checklist