Repository navigation
Keep the update window from stealing focus when an update is found in the background - #1396
Merged
Merged
Conversation
manuelmayer-dev
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1379
Summary
An update found by a background check now opens the update window without taking focus, and on Windows it waits while a fullscreen game, app or presentation is running. The Update to tray entry still brings the window to the front.
Testing
cargo fmt, clippy and cargo test pass, with new tests for the deferred offer. On Windows, a debug bootstrapper with a temporary offer trigger kept the foreground window unchanged and the update window still opened. Not tested with a real fullscreen game, on macOS or on Linux.
Notes
The host error window and the native update dialog fallback also take focus on their own; they were left as they are.
Checklist