Repository navigation
Fix the icon display reset on buttons with multiple states - #1419
Merged
Merged
Conversation
manuelmayer-dev
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1414
Summary
The icon display Reset sends null, which both Action Button framing setters dereferenced, so the host rejected the reset and the old framing came back. A reset now restores the default framing, stored explicitly per state so the deck does not fall back to the root framing.
Testing
Full solution build and test suites pass, with three new Action Button editor tests. Verified in a browser against a running host: Reset on a multi-state button stays at the defaults and is saved, other states keep their framing.
Checklist