Repository navigation
Center the Live and Offline pill in the Stream Stats widgets - #1441
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The red Live and grey Offline pill in the Twitch and YouTube Stream Stats widgets sat visibly left of centre. Inside the pill, the space before the dot was 0.2em and the space after the label was 0.3em, and the label's own right side bearing adds a little more on top of that. The spacers are now 0.25em before the dot and 0.2em after the label, so the dot and label sit centred in the pill.
The pill's vertical offset seen in the website screenshots is not changed here. It comes from how those screenshots were captured: a 2x1 tile in the Overview style, scaled up, with the device scale emulated over CDP. Rendered at a real device scale factor, the text is within 1 to 2 px of centre, apart from a small offset in that 2x1 tile at scale 1.
Testing
Notes
Checklist