Repository navigation
Fix NumLock and PrintScreen key actions doing nothing on Windows - #1458
Merged
Merged
Conversation
manuelmayer-dev
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1442
Summary
Keyboard actions on Windows injected NumLock as E0 45 and PrintScreen as E0 54, scan codes Windows maps to no key, so both did nothing. NumLock is now sent by virtual key with its scan code and PrintScreen with its physical scan code E0 37, so both arrive like the physical keys.
Testing
Windows platform tests pass, including new tests that resolve every key the host presses on US and German layouts and inject the lock keys, Pause and all extended keys through a low-level hook; they fail without the fix. Verified on Windows 11 against a running host (the NumLock action now toggles NumLock) and manually tested through the desktop UI.
Notes
Now that NumLock can be turned off from a deck, numpad digit actions act as navigation keys while it is off, like the physical numpad. A PrintScreen action now opens the Snipping Tool on Windows 11 by default.
Checklist