Repository navigation
Let plugin widgets run the user's actions when pressed - #960
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #934
Summary
Plugin widget types can set SupportsFlows on WidgetTypeDescriptor, and the host then runs a widget's stored flows on a press like it does for built-in widgets. Types that leave it unset behave as before.
Testing
Full build and all suites pass, including conformance and protocol, apart from two environment-only local failures that also fail on main. Verified with a scratch plugin on a running host: Web Client presses run an opted-in widget's flow and not a plain one's.
Plugin SDK / API compatibility
Notes
Double Tap on hardware decks is not recognised for these widgets; that part of the request is documented as a limitation and left for a follow-up.
Checklist