Repository navigation
Install and update the Companion App over ADB from the settings - #995
Merged
Merged
Conversation
manuelmayer-dev
added
feature
# Conflicts: # ui/angular/projects/desktop-ui/src/app/components/shell/settings-modal/settings-modal.component.spec.ts # ui/angular/projects/desktop-ui/src/app/components/shell/settings-modal/settings-modal.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue; requested by the maintainer.
Summary
Renames the Companion license settings page to Companion App and adds installing, updating and saving the Android app over ADB, with a trial notice when the host has no license. The APK comes from the published release manifest and is checked against its SHA-256 and a pinned signing certificate before use.
Testing
Full Release build and test suites passed before the account-sync merge (one Plugin CLI test fails on this Mac on main too); after it, the Release build and the licensing, companion, auth and settings suites pass, including the new host tests and desktop UI specs. Manually verified with a disposable host on a real Fire tablet and a Xiaomi phone: update detection, incompatible signature error, uninstall detection, fresh install of 26.1.0 and saving the APK.
Notes
This branch merges the branch of #994 (removes the test license), so that commit shows here until #994 is merged. Auto-update and relaunch after an update are covered by unit tests only, since there is no older direct-signed release to update from.
Checklist