Repository navigation
fix: leave num_epochs unset if max_steps is specified - #1107
Merged
Merged
Conversation
Signed-off-by: Andrei Doca <docaandrei62@yahoo.com>
Sparlitu
requested review from
HuiyingLi,
adil-a,
akoumpa and
hemildesai
as code owners
January 25, 2026 15:44
akoumpa
reviewed
Jan 26, 2026
Signed-off-by: Andrei Doca <docaandrei62@yahoo.com>
Contributor
|
/ok to test becd773 |
Contributor
|
/ok to test d00298e |
Sparlitu
commented
Jan 29, 2026
Contributor
Author
|
You're welcome @akoumpa. I hope I can contribute more for this project |
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Andrei Doca <docaandrei62@yahoo.com> Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
kashif
pushed a commit
to kashif/Automodel
that referenced
this pull request
May 25, 2026
Signed-off-by: Andrei Doca <docaandrei62@yahoo.com> Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR aims to fix the case where max_steps is specified in the scheduler and num_epochs is not, effectively defaulting to 10 and affecting the number of steps in training.
Changelog
num_epochsto be None ifmax_stepsis provided.num_epochsto 10 if nothing is set.test_scheduler_max_steps_priorityintests/unit_tests/components/training/test_step_scheduler.py.ruffformatting to modified files.Fixes #1095