Repository navigation
feat: add embeddings utils funcs to not added models - #1288
Merged
Merged
Conversation
SwekeR-463
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
as code owners
February 14, 2026 05:01
Signed-off-by: SwekeR-463 <swekerswasti@gmail.com>
SwekeR-463
force-pushed
the
feat/add-embed-utils
branch
from
February 14, 2026 05:08
a04ffe8 to
aaaa02a
Compare
Contributor
|
/ok to test 5619efe |
akoumpa
approved these changes
Feb 14, 2026
akoumpa
left a comment
akoumpa
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks a lot @SwekeR-463
Contributor
|
@NVIDIA-NeMo/automation this is ok to FM, please take a look when you get the chance. Thank you. |
akoumpa
pushed a commit
that referenced
this pull request
Feb 25, 2026
* feat: add i/o embeddings get and set funcs to not added models Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * .. Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> --------- Signed-off-by: SwekeR-463 <swekerswasti@gmail.com>
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
* feat: add i/o embeddings get and set funcs to not added models Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * .. Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> --------- Signed-off-by: SwekeR-463 <swekerswasti@gmail.com>
kashif
pushed a commit
to kashif/Automodel
that referenced
this pull request
May 25, 2026
* feat: add i/o embeddings get and set funcs to not added models Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * .. Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> --------- Signed-off-by: SwekeR-463 <swekerswasti@gmail.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
get_input_embeddings(),set_input_embeddings(),get_output_embeddings(), andset_output_embeddings()methods to models that were missing them.Changelog
Before your PR is "Ready for review"
Pre checks:
Additional Information