Repository navigation
fix: skip instantiation of nested configs overridden by kwargs in ConfigNode - #1397
Merged
Merged
Conversation
…figNode Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
oliverholworthy
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
as code owners
February 26, 2026 17:34
Contributor
Author
|
/ok to test b564933 |
akoumpa
approved these changes
Feb 26, 2026
akoumpa
left a comment
akoumpa
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot @oliverholworthy !
akoumpa
enabled auto-merge (squash)
February 26, 2026 18:16
akoumpa
disabled auto-merge
February 26, 2026 20:43
akoumpa
enabled auto-merge (squash)
February 26, 2026 20:43
Contributor
|
pipeline passed in https://github.com/NVIDIA-NeMo/Automodel/actions/runs/22453694117/job/65035858440 rerunning with docs-only to bypass codecov not reporting status |
Contributor
|
/ok to test b564933 |
thomasdhc
disabled auto-merge
February 26, 2026 20:54
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
…figNode (#1397) Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
kashif
pushed a commit
to kashif/Automodel
that referenced
this pull request
May 25, 2026
…figNode (NVIDIA-NeMo#1397) Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigNode.instantiate()unconditionally resolved all nested_target_configs via_instantiate_value()before applying**kwargsoverrides. When callers passed a pre-built object as a kwarg, the nested config was instantiated wastefully and the result immediately discarded.continueto skip_instantiate_value()for keys already present inkwargs.del cfg_dl.datasetin biencoder, lambda-wrappingcollate_fnin LLM fine-tuning).Pre checks: