Repository navigation
fix(inkling): support HF 5.14 attention fields and embed norm FSDP - #3281
Merged
Merged
Conversation
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/claude review |
HuiyingLi
force-pushed
the
huiyingl/fix/inkling-hf514-fsdp
branch
from
July 29, 2026 03:38
7b84f5d to
c01b6c2
Compare
HuiyingLi
marked this pull request as ready for review
July 29, 2026 03:40
Contributor
Author
|
/ok to test 7b84f5d |
@HuiyingLi, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Contributor
Author
|
/ok to test c01b6c2 |
hemildesai
approved these changes
Jul 29, 2026
Contributor
|
LGTM |
Contributor
Author
|
/ok to test 7d698b4 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attention_typefield and the Hugging Face 5.14layer_typefield when selecting Inkling causal maskshybridandhybrid_slidinglayer types to their corresponding causal-mask entriesembed_normits own FSDP unit and extend the parallelizer unit testRoot cause
Hugging Face 5.14 renamed the per-layer attention selector and stores Inkling-specific layer values instead of causal-mask keys. Separately, the multimodal forward invokes
language_model.embed_norm(...)before entering the text model's FSDP root forward, so a root-owned sharded weight can be used with a plain activation before the root pre-forward unshard hook runs.Validation
git diff --check