Repository navigation
fix: Raise informative error in MegatronPretraining if no glob paths found - #803
Merged
Merged
Conversation
Signed-off-by: James Bourbeau <jbourbeau@nvidia.com>
jrbourbeau
requested review from
HuiyingLi,
adil-a,
akoumpa and
hemildesai
as code owners
November 14, 2025 20:37
jrbourbeau
changed the title
MegatronPretraining if no glob paths foundMegatronPretraining if no glob paths found
Collaborator
|
/ok to test 7d29da7 |
Collaborator
|
Thanks a lot for the fix @jrbourbeau ! |
jrbourbeau
commented
Nov 14, 2025
jrbourbeau
left a comment
jrbourbeau
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for reviewing and adding a test @adil-a!
adil-a
approved these changes
Nov 15, 2025
chtruong814
pushed a commit
that referenced
this pull request
Nov 15, 2025
…ths found (#803) Signed-off-by: James Bourbeau <jbourbeau@nvidia.com> Co-authored-by: adil-a <adil.asif2000@hotmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
…ths found (#803) Signed-off-by: James Bourbeau <jbourbeau@nvidia.com> Co-authored-by: adil-a <adil.asif2000@hotmail.com>
kashif
pushed a commit
to kashif/Automodel
that referenced
this pull request
May 25, 2026
…ths found (NVIDIA-NeMo#803) Signed-off-by: James Bourbeau <jbourbeau@nvidia.com> Co-authored-by: adil-a <adil.asif2000@hotmail.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally had a bad glob path and got a confusing error here
Automodel/nemo_automodel/components/datasets/llm/megatron/megatron_utils.py
Lines 41 to 43 in de7dff9
when attempting to
zipan empty list (the list was only empty because of the glob path not being correct).This PR raises an informative error early on for the case that no glob paths are found.
EDIT: The particular case I was running was the pretraining example
where I didn't have the fineweb dataset downloaded locally