Skip to content

fix: NeMoAutoTokenizer - #878

Merged
chtruong814 merged 5 commits into
mainfrom
akoumparouli/fix_nemo_autotokenizer
Nov 24, 2025
Merged

chtruong814 merged 5 commits into
mainfrom
akoumparouli/fix_nemo_autotokenizer

Conversation

@akoumpa

@akoumpa akoumpa commented Nov 24, 2025 •

Copy link
Copy Markdown
Contributor

Previously, the code could prepend/append tokens inconsistently across items in the tokenization results (e.g., across input_ids, attention_mask, etc), causing issues in subsequence processing.

This fix ensures any token modification is consistent across items.

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 24, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa akoumpa changed the title fix fix: NeMoAutoTokenizer Nov 24, 2025
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa

akoumpa commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test fcbc194

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa

akoumpa commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test cc745e1

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa

akoumpa commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test fe6f48c

@akoumpa
akoumpa marked this pull request as ready for review November 24, 2025 20:13

@adil-a adil-a left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@chtruong814
chtruong814 merged commit 4cb1d5d into main Nov 24, 2025
51 of 52 checks passed
@chtruong814
chtruong814 deleted the akoumparouli/fix_nemo_autotokenizer branch November 24, 2025 20:27
chtruong814 pushed a commit that referenced this pull request Nov 24, 2025
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
linnanwang pushed a commit that referenced this pull request Apr 24, 2026
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
kashif pushed a commit to kashif/Automodel that referenced this pull request May 25, 2026
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

This branch was previously deployed

2 inactive deployments
nemo-ci — a2ba0d83 Deployed Nov 24, 2025 by copy-pr-bot[bot] via L2_LLM_KD #2703
test — a2ba0d83 Deployed Nov 24, 2025 by copy-pr-bot[bot] via cicd-wait-in-queue #2703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.2.0 Add for cherry-pick into release branch 0.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants