Skip to content

docs: Fix images not rendering in docs - #954

Merged
akoumpa merged 1 commit into
NVIDIA-NeMo:mainfrom
jrbourbeau:fix-image-rendering-docs
Dec 10, 2025
Merged

akoumpa merged 1 commit into
NVIDIA-NeMo:mainfrom
jrbourbeau:fix-image-rendering-docs

Conversation

@jrbourbeau

Copy link
Copy Markdown
Member

This PR fixes a few images I noticed we're rendering in the docs.

Before this PR:

Screenshot 2025-12-10 at 1 33 03 PM

After this PR:

Screenshot 2025-12-10 at 1 33 21 PM

Signed-off-by: James Bourbeau <jbourbeau@nvidia.com>
@jrbourbeau jrbourbeau changed the title Fix images not rendering in docs docs: Fix images not rendering in docs Dec 10, 2025
@thomasdhc
thomasdhc requested a review from akoumpa December 10, 2025 19:52
:class: bg-primary
:width: 600px
:align: center
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something the following work?

<img src="https://raw.githubusercontent.com/NVIDIA-NeMo/Automodel/refs/heads/main/docs/guides/fp8_convergence.jpg" alt="FP8 Convergence Comparison" width="600px" />

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using local files is probably better in this case (for example, there can be mismatches when doing development, versioning of docs, etc).

If you're looking for something that will render both in the docs and when viewed on GitHub, we would need to move away from myst markdown parsing. That's not always possible, but is in this case with something like this

diff --git a/docs/guides/omni/gemma3-3n.md b/docs/guides/omni/gemma3-3n.md
index ac11367..5443c93 100644
--- a/docs/guides/omni/gemma3-3n.md
+++ b/docs/guides/omni/gemma3-3n.md
@@ -218,12 +218,7 @@ peft:

 The training loss should look similar to the example below:

-```{image} medpix_peft.jpg
-:alt: Training Loss Curve
-:class: bg-primary
-:width: 400px
-:align: center
-```
+![Training Loss Curve](medpix_peft.jpg){.bg-primary w=400px align=center}

 ### Checkpointing

@akoumpa
akoumpa merged commit 5d8cf31 into NVIDIA-NeMo:main Dec 10, 2025
29 of 31 checks passed
@jrbourbeau
jrbourbeau deleted the fix-image-rendering-docs branch December 10, 2025 22:33
linnanwang pushed a commit that referenced this pull request Apr 24, 2026
Signed-off-by: James Bourbeau <jbourbeau@nvidia.com>
kashif pushed a commit to kashif/Automodel that referenced this pull request May 25, 2026
Signed-off-by: James Bourbeau <jbourbeau@nvidia.com>

This branch was previously deployed

1 inactive deployment
nemo-ci — 526fd587 Deployed Dec 10, 2025 by copy-pr-bot[bot] via Coverage_Fake #2854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants