Skip to content

Add GPTOSS Example with Megatron-LM + Megatron Bridge - #3018

Merged
faradawn merged 23 commits into
NVIDIA:mainfrom
faradawn:gptoss-example
Mar 2, 2026
Merged

faradawn merged 23 commits into
NVIDIA:mainfrom
faradawn:gptoss-example

Conversation

@faradawn

@faradawn faradawn commented Jan 20, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do ?

This PR adds examples for

  • Convert checkpoints from HF to Megatron format using Megatron Bridge
  • Train GPT-OSS with Megatron-LM
  • Convert the final Megatron checkpoint to HF format.

Tested on B300 with 8 GPUS.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot

copy-pr-bot Bot commented Jan 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team January 20, 2026 18:11
@faradawn

Copy link
Copy Markdown
Contributor Author

Hi @sbhavani this PR is ready. Do you know how to added the "Expert Review" Label? I cannot find a "gear icon". cc @AlphaBladez

@sbhavani sbhavani added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Jan 27, 2026
@sbhavani
sbhavani self-requested a review January 27, 2026 23:58
Comment thread examples/gptoss/README.md
Comment thread examples/gptoss/README.md Outdated
Comment thread examples/gptoss/README.md Outdated
Comment thread examples/gptoss/02_train.sh Outdated
Comment thread examples/gptoss/02_train.sh
@faradawn
faradawn enabled auto-merge February 26, 2026 17:18
@faradawn

Copy link
Copy Markdown
Contributor Author

/ok to test bea7657

Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
@faradawn

Copy link
Copy Markdown
Contributor Author

/ok to test e174421

@faradawn
faradawn added this pull request to the merge queue Feb 27, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22498684637

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 27, 2026
@faradawn
faradawn enabled auto-merge March 2, 2026 18:38
@faradawn

faradawn commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e174421

@copy-pr-bot

copy-pr-bot Bot commented Mar 2, 2026

Copy link
Copy Markdown

/ok to test e174421

@faradawn, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@faradawn

faradawn commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test b5bab00

@faradawn
faradawn added this pull request to the merge queue Mar 2, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22594348824

Merged via the queue into NVIDIA:main with commit 2f8c9bc Mar 2, 2026
52 of 53 checks passed
@faradawn
faradawn deleted the gptoss-example branch March 2, 2026 21:44
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Co-authored-by: Sachin Beldona <sbeldona@nvidia.com>
Co-authored-by: Sachin Beldona <34044296+AlphaBladez@users.noreply.github.com>
ilml added a commit to ilml/Megatron-LM that referenced this pull request Mar 20, 2026
…tron Bridge (NVIDIA#3018)

New files:
  - examples/gptoss/01_convert_from_hf.py
  - examples/gptoss/02_train.sh
  - examples/gptoss/03_convert_to_hf.py
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Co-authored-by: Sachin Beldona <sbeldona@nvidia.com>
Co-authored-by: Sachin Beldona <34044296+AlphaBladez@users.noreply.github.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Co-authored-by: Sachin Beldona <sbeldona@nvidia.com>
Co-authored-by: Sachin Beldona <34044296+AlphaBladez@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
test — b5bab004 Deployed Mar 2, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #8964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants