Skip to content

Fix incorrect inference metadata tensor dtypes - #4855

Merged
santhnm2 merged 34 commits into
NVIDIA:mainfrom
santhnm2:batch_indices_decode_fix
Jun 3, 2026
Merged

santhnm2 merged 34 commits into
NVIDIA:mainfrom
santhnm2:batch_indices_decode_fix

Conversation

@santhnm2

Copy link
Copy Markdown
Contributor

What does this PR do ?

Ensures token_to_block_idx uses int64 consistently. Otherwise, we were seeing numerical overflow when the number of blocks exceeded 2^16. Also makes batch_indices_decode int64 consistently.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

santhnm2 added 5 commits May 18, 2026 10:57
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@santhnm2

Copy link
Copy Markdown
Contributor Author

/ok to test 8945ac8

Comment thread megatron/core/inference/contexts/dynamic_context.py
Comment thread megatron/core/inference/contexts/gpu_view.py
Comment thread tests/unit_tests/inference/contexts/test_fused_kv_append_kernel.py Outdated
@tdene

tdene commented May 19, 2026

Copy link
Copy Markdown
Contributor

@santhnm2 @lmcafee-nvidia why not just keep all the metadata in int64 to prevent any such issues from popping up? It's not going to be a large memory cost.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2

Copy link
Copy Markdown
Contributor Author

@santhnm2 @lmcafee-nvidia why not just keep all the metadata in int64 to prevent any such issues from popping up? It's not going to be a large memory cost.

Yea I think we need to clean this up, will defer to a later PR though because it may end up breaking other things unintentionally

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Comment thread megatron/core/inference/engines/dynamic_engine.py Outdated
@santhnm2
santhnm2 removed request for a team May 26, 2026 19:18
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 26, 2026
@santhnm2

santhnm2 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 13888ad

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Jun 3, 2026
@santhnm2
santhnm2 enabled auto-merge June 3, 2026 19:57
@santhnm2
santhnm2 added this pull request to the merge queue Jun 3, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26912497258

Merged via the queue into NVIDIA:main with commit e513ec4 Jun 3, 2026
133 of 137 checks passed

This branch was previously deployed

2 inactive deployments
public — 13888ad2 Deployed Jun 3, 2026 by copy-pr-bot[bot] via finalize / publish-docs #1504
test — 13888ad2 Deployed Jun 3, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #14701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.