Optimized support for applying exponentials of Paulis by amccaskey · Pull Request #660 · NVIDIA/cuda-quantum

amccaskey · 2023-09-15T14:01:53Z

Enable the following in the runtime and the bridge:

auto kernel = [](double theta) __qpu__ {
  cudaq::qreg q(4);
  x(q[0]);
  x(q[1]);
  exp_pauli(theta, q, "XXXY");
};

auto kernel2 = [](double theta, const char * pauli) __qpu__ {
   cudaq::qreg q(4);
   x(q[0]);
   x(q[1]);
   exp_pauli(theta, q, pauli);
 };

auto kernel3 = [](double theta) __qpu__ {
  cudaq::qreg q(4);
  x(q[0]);
  x(q[1]);
  exp_pauli(theta, "XXXY", q[0], q[1], q[2], q[3]);
};

auto [kernel, theta] = cudaq::make_kernel<double>();
auto qubits = kernel.qalloc(4);
kernel.x(qubits[0]);
kernel.x(qubits[1]);
kernel.exp_pauli(theta, qubits, "XXXY");

auto [kernel, theta] = cudaq::make_kernel<double>();
auto qubits = kernel.qalloc(4);
kernel.x(qubits[0]);
kernel.x(qubits[1]);
kernel.exp_pauli(theta, "XXXY", qubits[0], qubits[1], qubits[2], qubits[3]);

kernel, theta = cudaq.make_kernel(float)
qubits = kernel.qalloc(4)
kernel.x(qubits[0])
kernel.x(qubits[1])
kernel.exp_pauli(theta, qubits, "XXXY")

Also:

Add a cc.string type, a cc.string_literal op, and updates to lower to all this LLVM.

copy-pr-bot · 2023-09-15T14:01:57Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

amccaskey · 2023-09-15T15:16:45Z

Command Bot: Processing...

amccaskey · 2023-09-15T23:58:03Z

Command Bot: Processing...

amccaskey · 2023-09-16T12:47:26Z

Command Bot: Processing...

1tnguyen · 2023-09-18T13:30:05Z

I couldn't reproduce the segfault in https://github.com/NVIDIA/cuda-quantum/actions/runs/6207439851/job/16853577621 locally:

Download the wheel artifact (pycudaq-3-11-manylinux-amd64-gcc11-pr-660) in https://github.com/NVIDIA/cuda-quantum/actions/runs/6207439851/attempts/1
Start a clean Ubuntu22.04 image and install Python3.11 then install that wheel.
Clone the repo then run Python tests in python/tests/unittests

All the expected tests are passing

============================================================ 215 passed, 9 skipped in 334.64s (0:05:34) =============================================================

Detail run of the failing test_kernel_builder.py test

root@85f386355464:~/cuda-quantum/python/tests/unittests# python3.11 -m pytest -v test_kernel_builder.py 
======================================================================== test session starts ========================================================================
platform linux -- Python 3.11.0rc1, pytest-7.4.2, pluggy-1.3.0 -- /usr/bin/python3.11
cachedir: .pytest_cache
rootdir: /root/cuda-quantum/python/tests/unittests
collected 11 items                                                                                                                                                  

test_kernel_builder.py::test_sdg_0_state PASSED                                                                                                               [  9%]
test_kernel_builder.py::test_sdg_1_state PASSED                                                                                                               [ 18%]
test_kernel_builder.py::test_sdg_0_state_negate PASSED                                                                                                        [ 27%]
test_kernel_builder.py::test_sdg_1_state_negate PASSED                                                                                                        [ 36%]
test_kernel_builder.py::test_tdg_0_state PASSED                                                                                                               [ 45%]
test_kernel_builder.py::test_tdg_1_state PASSED                                                                                                               [ 54%]
test_kernel_builder.py::test_tdg_0_state_negate PASSED                                                                                                        [ 63%]
test_kernel_builder.py::test_tdg_1_state_negate PASSED                                                                                                        [ 72%]
test_kernel_builder.py::test_can_progressively_build PASSED                                                                                                   [ 81%]
test_kernel_builder.py::test_from_state PASSED                                                                                                                [ 90%]
test_kernel_builder.py::test_exp_pauli PASSED                                                                                                                 [100%]

======================================================================== 11 passed in 3.31s =========================================================================

amccaskey · 2023-09-18T21:39:14Z

Command Bot: Processing...

poojarao8 · 2023-09-25T22:01:54Z

This looks great and it'd be really useful in several ongoing projects with partners. Is there any way we can bump this up? @bettinaheim

amccaskey · 2023-09-26T12:06:33Z

Command Bot: Processing...

amccaskey · 2023-09-26T12:44:05Z

Command Bot: Processing...

amccaskey · 2023-09-26T17:43:35Z

Command Bot: Processing...

amccaskey · 2023-09-26T18:16:54Z

Command Bot: Processing...

amccaskey · 2023-09-26T19:15:49Z

Command Bot: Processing...

amccaskey · 2023-09-26T19:41:10Z

documenting this, for some reason on CI, we get a function call from libnvqir-custatevec-fp32?

Thread 1 "python3.11" received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
#0  0x0000000000000000 in ?? ()
#1  0x00007f94325425eb in std::_Function_handler<void (bool), nvqir::CircuitSimulator::applyExpPauli(double, std::vector<unsigned long, std::allocator<unsigned long> > const&, cudaq::spin_op const&)::{lambda(cudaq::pauli, unsigned long)#1}::operator()(cudaq::pauli, unsigned long) const::{lambda(bool)#2}>::_M_invoke(std::_Any_data const&, bool&&) ()
   from /root/.local/lib/python3.11/site-packages/cudaq/../lib/libnvqir-custatevec-fp32.so
#2  0x00007f94324c2d4e in ?? ()
   from /root/.local/lib/python3.11/site-packages/cudaq/../lib/libnvqir-qpp.so
#3  0x00007f945faffbef in __quantum__qis__exp_pauli ()
   from /root/.local/lib/python3.11/site-packages/cudaq/../lib/libnvqir.so
#4  0x00007f946105f0b4 in __nvqpp__mlirgen____nvqppBuilderKernel_108506462586
    ()
#5  0x00007f946105f1b1 in __nvqppBuilderKernel_108506462586.thunk ()
#6  0x00007f945fce3e33 in ?? ()
   from /root/.local/lib/python3.11/site-packages/cudaq/../lib/libcudaq-platform-default.so
#7  0x00007f945fb532d5 in altLaunchKernel ()

amccaskey · 2023-09-26T19:42:57Z

Command Bot: Processing...

amccaskey · 2023-09-27T00:17:34Z

Command Bot: Processing...

amccaskey · 2023-09-27T00:25:57Z

Command Bot: Processing...

schweitzpgi · 2023-09-27T21:40:53Z

Command Bot: Processing...

amccaskey · 2023-09-27T23:06:44Z

Command Bot: Processing...

amccaskey · 2023-09-27T23:41:45Z

Command Bot: Processing...

github-actions · 2023-09-28T00:05:42Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

schweitzpgi

nits.

Looks good to me, but I helped write the code. :) @1tnguyen can you take a look?

amccaskey · 2023-09-28T23:24:42Z

Command Bot: Processing...

github-actions · 2023-09-28T23:49:29Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

Convert the headers to use ASCIIZ string literals for the final argument to exp_pauli(). (Simplifies the AST presented to the bridge and falls back to using code that handles string literals.) Update LowerToQIR for the new types, fix bugs. Fix up tests.

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

amccaskey · 2023-09-29T12:57:18Z

Command Bot: Processing...

github-actions · 2023-09-29T13:20:45Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1tnguyen

LGTM 👍

Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

amccaskey · 2023-09-29T21:33:38Z

Command Bot: Processing...

github-actions · 2023-09-29T21:58:27Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

amccaskey requested review from 1tnguyen and schweitzpgi September 15, 2023 14:01

amccaskey requested review from bettinaheim and bmhowe23 as code owners September 16, 2023 12:47

schweitzpgi reviewed Sep 19, 2023

View reviewed changes

Comment thread include/cudaq/Optimizer/Dialect/Quake/QuakeOps.td

schweitzpgi reviewed Sep 19, 2023

View reviewed changes

Comment thread include/cudaq/Optimizer/Dialect/Quake/QuakeOps.td Outdated

schweitzpgi reviewed Sep 19, 2023

View reviewed changes

Comment thread lib/Optimizer/CodeGen/LowerToQIR.cpp

1tnguyen mentioned this pull request Sep 27, 2023

Potential symbol collision when pre-loading multiple sim libs in LinkedLibraryHolder (Python) #698

Open

github-actions Bot pushed a commit that referenced this pull request Sep 28, 2023

Docs preview for PR #660.

b827599

amccaskey requested a review from schweitzpgi September 28, 2023 00:11

schweitzpgi reviewed Sep 28, 2023

View reviewed changes

Comment thread include/cudaq/Optimizer/Dialect/Quake/QuakeOps.td

schweitzpgi reviewed Sep 28, 2023

View reviewed changes

Comment thread runtime/cudaq/builder/kernel_builder.cpp Outdated

Comment thread test/AST-Quake/exp-pauli-1.cpp Outdated

Comment thread test/AST-Quake/exp-pauli-2.cpp Outdated

Comment thread unittests/CMakeLists.txt Outdated

github-actions Bot pushed a commit that referenced this pull request Sep 28, 2023

Docs preview for PR #660.

0ba12a4

amccaskey and others added 7 commits September 29, 2023 12:55

Add exp_pauli quantum instruction to the runtime and ASTBridge

428b153

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

build fixes, still have to fix the wheel validation

6f97216

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

cleanup, add qpp applyExpPauli impl

5622a0d

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

fix docs gen

3ec4ce8

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

clean up

d3a1f01

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

clean up, provide docs

95f2641

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>

github-actions Bot pushed a commit that referenced this pull request Sep 29, 2023

Docs preview for PR #660.

9517ad0

1tnguyen reviewed Sep 29, 2023

View reviewed changes

Comment thread runtime/nvqir/custatevec/CuStateVecCircuitSimulator.cu Outdated

1tnguyen reviewed Sep 29, 2023

View reviewed changes

Comment thread runtime/nvqir/qpp/QppCircuitSimulator.cpp

1tnguyen approved these changes Sep 29, 2023

View reviewed changes

schweitzpgi added the enhancement New feature or request label Sep 29, 2023

schweitzpgi added this to the release 0.5.0 milestone Sep 29, 2023

schweitzpgi and others added 2 commits September 29, 2023 10:21

Merge branch 'main' into applyExpPauli

0711e2e

Update runtime/nvqir/custatevec/CuStateVecCircuitSimulator.cu

761ff40

Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>

github-actions Bot pushed a commit that referenced this pull request Sep 29, 2023

Docs preview for PR #660.

f91c514

schweitzpgi merged commit da6d0b9 into NVIDIA:main Sep 29, 2023

github-actions Bot locked and limited conversation to collaborators Sep 29, 2023

bettinaheim changed the title ~~Add exp_pauli quantum instruction to the runtime and ASTBridge~~ Add exp_pauli quantum instruction Nov 15, 2023

bettinaheim changed the title ~~Add exp_pauli quantum instruction~~ Optimized support for applying exponentials of Paulis Nov 15, 2023

amccaskey deleted the applyExpPauli branch February 29, 2024 20:30

Conversation

amccaskey commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot Bot commented Sep 15, 2023

Uh oh!

amccaskey commented Sep 15, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 15, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 16, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1tnguyen commented Sep 18, 2023

Uh oh!

amccaskey commented Sep 18, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

poojarao8 commented Sep 25, 2023

Uh oh!

amccaskey commented Sep 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 26, 2023

Uh oh!

amccaskey commented Sep 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 27, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 27, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schweitzpgi commented Sep 27, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 27, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amccaskey commented Sep 27, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2023

Uh oh!

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amccaskey commented Sep 28, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2023

Uh oh!

amccaskey commented Sep 29, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 29, 2023

Uh oh!

amccaskey commented Sep 15, 2023 •

edited

Loading

amccaskey commented Sep 15, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 15, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 16, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 18, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 26, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 26, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 26, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 26, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 26, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 26, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 27, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 27, 2023 •

edited by github-actions Bot

Loading

schweitzpgi commented Sep 27, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 27, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 27, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 28, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 29, 2023 •

edited by github-actions Bot

Loading

amccaskey commented Sep 29, 2023 •

edited by github-actions Bot

Loading