Repository navigation
Add more support for std::vector and (C style) arrays. - #714
Merged
Merged
Conversation
schweitzpgi
force-pushed
the
ch-vector.e2e
branch
from
September 28, 2023 22:26
ca1428e to
88f17a1
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
reviewed
Sep 28, 2023
bmhowe23
approved these changes
Sep 29, 2023
bmhowe23
left a comment
bmhowe23
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Just a few comments below.
schweitzpgi
enabled auto-merge (squash)
September 29, 2023 14:36
This relates to issue NVIDIA#490. These changes help pave the way for using std::vector<bool>, bool[N], and AT[N] typed local variables in quantum kernels. Fix and add new test. Extend test per review comment.
schweitzpgi
force-pushed
the
ch-vector.e2e
branch
from
September 29, 2023 14:41
3f66e17 to
c98dba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to issue #490. These changes help pave the way for using
std::vector<bool>, bool[N], and AT[N] typed local variables in quantum kernels.