Repository navigation

Support for adaptive quantum kernels on (certain) quantum hardware backends - #741

Merged

bmhowe23 merged 21 commits into

NVIDIA:mainfrom

bmhowe23:pr-adaptive-profile

Oct 16, 2023

Merged

Support for adaptive quantum kernels on (certain) quantum hardware backends#741
bmhowe23 merged 21 commits into
NVIDIA:mainfrom
bmhowe23:pr-adaptive-profile

bmhowe23 commented Oct 4, 2023 •

edited

Loading

Collaborator

Summary

This PR builds on #724 by adding initial cuda-quantum support for the Adaptive Profile, as defined here. The PR is broken into 5 separate commits to aid the review process. The important functional changes are in 66ca0a2, and the other commits cover tests and emulation updates.

Testing Details

8 new tests were added. Some of them are currently marked as XFAIL (reasons described in the individual comments). Some of the failures are only occurring due to emulation issues.

The following 6 new tests all successfully run and pass built-in assertion checks on Quantinuum's H1-1E server.

qir_test_cond_for_loop-1.cpp
qir_test_cond_for_loop-2.cpp
qir_test_cond_for_loop-3.cpp
qir_test_cond_for_loop-4.cpp
qir_test_cond_for_loop-5.cpp
qir_test_simple_cond-1.cpp

The following 2 previously existing tests also successfully run on Quantinuum's H1-1E server.

testConditionalSample.cpp
testIQPE_Conditionals.cpp

Selected tests will be added to the Nightly Integration jobs in a future PR, but this PR must be reviewed and approved first.

Adaptive Profile Test Summary

Test	Emulate	H1-1E	Comment
qir_test_cond_for_break	❌	❌	'cc.loop' op not a simple counted loop (#781)
qir_test_cond_for_loop-1	✅	✅
qir_test_cond_for_loop-2	✅	✅
qir_test_cond_for_loop-3	✅	✅
qir_test_cond_for_loop-4	❌	✅	It's not setting `qubitMeasurementFeedback` correctly (#782)
qir_test_cond_for_loop-5	❌	✅	It's not setting `qubitMeasurementFeedback` correctly (#782)
qir_test_cond_for_loop-6	✅	❌	Results returned for skipped loops (#783)
qir_test_simple_cond-1	✅	✅
qir_test_simple_cond-2	❌	❌	Won't pass until opt. capabilities of the Adaptive Profile are added
testConditionalSample	✅	✅	Assertions may need further attention to allow for noise in `H1-E1`
testIQPE_Conditionals	✅	✅

bmhowe23 added 5 commits

October 4, 2023 16:13


          Allow OQC email and password to be undefined for local emulation

58da0ff


          Actual changes to support Adaptive Profile

66ca0a2

- Add createReadResults back
- Add LoadMeasureResult back
- Update to use resultQubitVals instead of resultPtrValues
- Add qubit_resetting module flags (and other module flags)
- Make adaptive profile remote emulation work


          Add named blocks to work around PyQIR limitation

e3ac941


          Properly set qubitMeasurementFeedback for array-saved measurements

97dfb88


          Add new adaptive profile tests and update old ones

780a86d

Add/update tests

qir_test_cond_for_loop*.cpp updates

Add XFAIL on new test due to unknown emulation issue

Update some adaptive profile tests

Add base profile target to existing test

Update tests

Add qir_test_cond_for_break.cpp

Add newlines at end of test files

Even more new tests after finding sensitivity for setting the
qubitMeasurementFeedback attribute correctly.

bmhowe23 added this to the release 0.5.0 milestone

bmhowe23 added release notes enhancement labels


          Create __quantum__qis__read_result__body stub in NVQIR

a17e453

github-actions Bot commented Oct 4, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

51d6a77

bmhowe23 added 2 commits

October 5, 2023 15:30


          Add qir_test_cond_for_loop-6.cpp (XFAIL), which shows a compiler issue

19ac07c


          Merge branch 'main' into pr-adaptive-profile

5b804e9

github-actions Bot commented Oct 5, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

1dba700

bmhowe23 mentioned this pull request

Add Support for Adaptive Profile QIR #745

Closed

3 of 5 tasks


          Merge branch 'main' into pr-adaptive-profile

5df7f24

schweitzpgi reviewed

View reviewed changes

schweitzpgi left a comment

Collaborator

Not done yet, but submitting what I have...

include/cudaq/Optimizer/CodeGen/Peephole.h

lib/Optimizer/CodeGen/LowerToQIRProfile.cpp

lib/Optimizer/Transforms/QuakeAddMetadata.cpp

lib/Optimizer/Transforms/QuakeAddMetadata.cpp

runtime/common/RuntimeMLIR.cpp Outdated

runtime/common/RuntimeMLIR.cpp

runtime/common/RuntimeMLIR.cpp

github-actions Bot commented Oct 6, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

34e41bf

bmhowe23 added 2 commits

October 6, 2023 19:54


          Merge branch 'main' into pr-adaptive-profile

f15c5c7


          Comments and function rename

f1e6886

This was referenced Oct 6, 2023

Need to make QuakeAddMetadataPass more robust #749

Closed

Sampling with mid-circuit measurements in emulated target mode #364

Closed

schweitzpgi reviewed

View reviewed changes

lib/Optimizer/Transforms/QuakeAddMetadata.cpp

runtime/common/RuntimeMLIR.cpp

runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp

runtime/cudaq/platform/default/rest/helpers/quantinuum/quantinuum.config

runtime/nvqir/NVQIR.cpp

test/NVQPP/qir_test_cond_for_loop-1.cpp Outdated

bmhowe23 commented Oct 9, 2023 •

edited by github-actions Bot

Loading

Collaborator Author

/create_cache

Command Bot: Processing...
The launched workflow can be found here.
Running workflow from branch main. The created cache will be owned by that branch.
Checking out source code from head bmhowe23:pr-adaptive-profile (sha: f1e6886).

bmhowe23 added 3 commits

October 10, 2023 14:47


          Merge branch 'main' into pr-adaptive-profile

41f712d


          Update PyQIR comment

1f08eee


          Use FileCheck instead of asserts in new tests

d90e40e

github-actions Bot commented Oct 10, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

e6f7706

bmhowe23 mentioned this pull request

Add support for __quantum__qis__read_result__body in Quantinuum Mock Server for Python #758

Open

1 task done

bmhowe23 and others added 2 commits

October 10, 2023 18:36


          Add reference to new issue for __quantum__qis__read_result__body

d57dbe2


          Merge branch 'main' into pr-adaptive-profile

8d695ec

github-actions Bot commented Oct 11, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

4f53c42


          Merge branch 'main' into pr-adaptive-profile

5c5104d

github-actions Bot commented Oct 11, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

570b123

github-actions Bot commented Oct 11, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

2e15b58

github-actions Bot commented Oct 12, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

10ebfca


          Merge branch 'main' into pr-adaptive-profile

3c3d32f

github-actions Bot commented Oct 12, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

ff6b83a

bmhowe23 added 2 commits

October 12, 2023 22:03


          Update tests for latest merge

c6a947a


          More test updates

a362068

github-actions Bot commented Oct 12, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

db6cf7f

schweitzpgi approved these changes

View reviewed changes

schweitzpgi reviewed

View reviewed changes

test/NVQPP/qir_test_cond_for_break.cpp


          Merge branch 'main' into pr-adaptive-profile

9f94f1b

github-actions Bot commented Oct 16, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request


          Docs preview for PR #741.

bmhowe23 mentioned this pull request

Unit test failure: test/NVQPP/qir_test_cond_for_break.cpp #781

Closed

2 of 3 tasks

bmhowe23 closed this

github-actions Bot locked and limited conversation to collaborators

bettinaheim changed the title ~~Add Support for the QIR Adaptive Profile~~ Support for the QIR Adaptive Profile

bettinaheim changed the title ~~Support for the QIR Adaptive Profile~~ Support for adaptive quantum kernels on (certain) quantum hardware backends

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement release notes