Skip to content

Fix bug in loop normalization. - #807

Merged
schweitzpgi merged 1 commit into
NVIDIA:mainfrom
schweitzpgi:ch-bug.norm
Oct 23, 2023
Merged

schweitzpgi merged 1 commit into
NVIDIA:mainfrom
schweitzpgi:ch-bug.norm

Conversation

@schweitzpgi

Copy link
Copy Markdown
Collaborator

Loop normalization was mistakenly adding back the linear expression from the condition expression to compute the current value of the induction in the body. Remove that code and add a regression test.

@schweitzpgi schweitzpgi added the bug fix To be listed under Bug Fixes in the release notes label Oct 20, 2023
@schweitzpgi schweitzpgi added this to the release 0.5.0 milestone Oct 20, 2023
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 20, 2023
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 23, 2023
@schweitzpgi
schweitzpgi enabled auto-merge (squash) October 23, 2023 17:11
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 23, 2023
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 23, 2023
Loop normalization was mistakenly adding back the linear expression from
the condition expression to compute the current value of the induction
in the body. Remove that code and add a regression test.
@copy-pr-bot

copy-pr-bot Bot commented Oct 23, 2023

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@schweitzpgi

schweitzpgi commented Oct 23, 2023 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@schweitzpgi
schweitzpgi merged commit 9e1dc26 into NVIDIA:main Oct 23, 2023
@schweitzpgi
schweitzpgi deleted the ch-bug.norm branch October 23, 2023 19:18
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants