Repository navigation
Better support for QuakeValue in Python - #809
Merged
Merged
Conversation
- Support division - Fix bug in Quake for_loop: we missed a cast to index type when the start index is a QuakeValue.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
approved these changes
Oct 23, 2023
amccaskey
left a comment
amccaskey
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Do you need to add a test for the C++ in builder_tester.cpp?
Collaborator
Author
|
Thanks! I've added equivalent checks for C++ |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
added
the
release notes
bettinaheim
changed the title
QuakeValue in PythonQuakeValue in Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support division (resolved Additional support for Quake values in Python #754)
Fix bug in Quake
for_loop: we missed a cast to index type when the start index is aQuakeValue.Also, fix first tutorial, showing the use of
expectation()to retrieve the expectation result (dumping the result will show empty counts distribution since we don't do shots-based sampling).