Skip to content

Incorporate new qubit-mapping pass for OQC backends - #838

Merged
bmhowe23 merged 8 commits into
NVIDIA:mainfrom
bmhowe23:placement_oqc
Nov 2, 2023
Merged

Incorporate new qubit-mapping pass for OQC backends#838
bmhowe23 merged 8 commits into
NVIDIA:mainfrom
bmhowe23:placement_oqc

Conversation

@bmhowe23

@bmhowe23 bmhowe23 commented Oct 30, 2023 •
edited by bettinaheim
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR contains the necessary changes for the OQC backend to use the new qubit mapping infrastructure. It therefore depends on #610 and #837.

Details

  • Update oqc.config to include new passes
  • Update output ordering logic to account for the swaps that can now be injected into the program during the qubit-mapping pass.
  • Update tests

@copy-pr-bot

copy-pr-bot Bot commented Oct 30, 2023

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23

bmhowe23 commented Oct 30, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@github-actions

github-actions Bot commented Oct 30, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #838.
a385608
@bmhowe23 bmhowe23 mentioned this pull request Oct 30, 2023
Closed
6 of 12 tasks
oarnold-oqc
oarnold-oqc reviewed Oct 30, 2023
View reviewed changes
Comment thread runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp
@bmhowe23

bmhowe23 commented Oct 30, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@github-actions

github-actions Bot commented Oct 30, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #838.
070c31c
@github-actions

github-actions Bot commented Oct 31, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Oct 31, 2023
@cuda-quantum-bot
Docs preview for PR #838.
531eeb8
@github-actions

github-actions Bot commented Nov 1, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 1, 2023
@cuda-quantum-bot
Docs preview for PR #838.
2455522
@github-actions

github-actions Bot commented Nov 1, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 1, 2023
@cuda-quantum-bot
Docs preview for PR #838.
f380b1e
@bmhowe23 bmhowe23 added the enhancement New feature or request label Nov 1, 2023
@bmhowe23 bmhowe23 added this to the release 0.5.0 milestone Nov 1, 2023
@github-actions

github-actions Bot commented Nov 1, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 1, 2023
@cuda-quantum-bot
Docs preview for PR #838.
bf024c6
@bmhowe23 bmhowe23 changed the title [DRAFT] Incorporate new qubit-mapping pass for OQC backends Incorporate new qubit-mapping pass for OQC backends Nov 2, 2023
@github-actions

github-actions Bot commented Nov 2, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
a7a0ddf
@bmhowe23 bmhowe23 mentioned this pull request Nov 2, 2023
Merged
@github-actions

github-actions Bot commented Nov 2, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
8e9ae38
schweitzpgi
schweitzpgi approved these changes Nov 2, 2023
View reviewed changes

@schweitzpgi schweitzpgi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread runtime/common/MeasureCounts.cpp
Comment thread runtime/cudaq/platform/default/rest/Executor.cpp
Comment thread runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated
Comment thread runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated
Comment thread runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated
Comment thread runtime/cudaq/platform/default/rest/helpers/oqc/oqc.config
@github-actions

github-actions Bot commented Nov 2, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
a6f45da
@github-actions

github-actions Bot commented Nov 2, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
f56ebab
@bmhowe23 bmhowe23 closed this Nov 2, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2023
@bettinaheim bettinaheim added release notes Changes need to be captured in the release notes and removed enhancement New feature or request labels Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes
@bettinaheim bettinaheim Awaiting requested review from bettinaheim
@anthony-santana anthony-santana Awaiting requested review from anthony-santana
@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen
@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya
+1 more reviewer
@oarnold-oqc oarnold-oqc oarnold-oqc left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bmhowe23 @schweitzpgi @oarnold-oqc @bettinaheim