Skip to content

Open-source tensornet simulator and add tensornet-mps simulator backend - #863

Merged
1tnguyen merged 17 commits into
NVIDIA:mainfrom
1tnguyen:tnguyen/tensornet
Nov 9, 2023
Merged

1tnguyen merged 17 commits into
NVIDIA:mainfrom
1tnguyen:tnguyen/tensornet

Conversation

@1tnguyen

@1tnguyen 1tnguyen commented Nov 6, 2023 •

Copy link
Copy Markdown
Collaborator

Description

  • Add tensornet and mps backends based on cuquantum 23.10 release.

  • Modified Dockerfile to use the the latest cuquantum.

  • Include the new backends in the runtime test suite: escaping some tests that are not suitable for tensornet backends: conditional circuits with many shots (long test time) and multi-qubit (> 2) gates on MPS.

@github-actions

github-actions Bot commented Nov 6, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Comment thread unittests/integration/ghz_nisq_tester.cpp
@1tnguyen 1tnguyen added this to the release 0.5.0 milestone Nov 6, 2023
@github-actions

github-actions Bot commented Nov 6, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 6, 2023
@github-actions

github-actions Bot commented Nov 7, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 7, 2023
Comment thread runtime/nvqir/cutensornet/simulator_cutensornet.cpp
Comment thread runtime/nvqir/cutensornet/simulator_cutensornet.cpp
Comment thread runtime/nvqir/cutensornet/simulator_cutensornet.cpp Outdated
Comment thread runtime/nvqir/cutensornet/tensornet_spin_op.cpp Outdated
Comment thread runtime/nvqir/cutensornet/tensornet_spin_op.cpp Outdated
Comment thread runtime/nvqir/cutensornet/tensornet_state.cpp Outdated
Comment thread runtime/nvqir/cutensornet/tensornet_state.cpp Outdated
Comment thread runtime/nvqir/cutensornet/tensornet_state.cpp
Comment thread runtime/nvqir/cutensornet/tensornet_state.cpp Outdated
1tnguyen and others added 2 commits November 8, 2023 14:54
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 8, 2023
@1tnguyen

1tnguyen commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator Author

Test logs for the runtime test suite (unittests/) for these 2 backends:

@github-actions

github-actions Bot commented Nov 9, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Comment thread unittests/integration/ghz_nisq_tester.cpp

@bettinaheim bettinaheim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Comment thread docs/sphinx/examples/cpp/basics/cutensornet_backends.cpp Outdated
Thanks @bmhowe23 for spotting them.

- Dead `default` switch case. Clang doesn't like it.

- Missing a default virtual destructor and one inconsistent declaration.

- Update the example to be generic with/without cutensornet MPI support.
@github-actions

github-actions Bot commented Nov 9, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 9, 2023
@github-actions

github-actions Bot commented Nov 9, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 9, 2023

@bmhowe23 bmhowe23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Thien 👍

@khalatepradnya

Copy link
Copy Markdown
Collaborator

Q: Do these simulator backends have configuration files?

@1tnguyen

1tnguyen commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator Author

Q: Do these simulator backends have configuration files?

Yes, they have. The config files are auto generated and installed by CMake.

@github-actions

github-actions Bot commented Nov 9, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 9, 2023
@1tnguyen
1tnguyen merged commit a8123e4 into NVIDIA:main Nov 9, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2023
@bettinaheim bettinaheim added the enhancement New feature or request label Nov 15, 2023
@bettinaheim bettinaheim changed the title Add cutensornet-based simulator backends Open-source tensornet simulator and add tensornet-mps simulator backend. Nov 15, 2023
@bettinaheim bettinaheim changed the title Open-source tensornet simulator and add tensornet-mps simulator backend. Open-source tensornet simulator and add tensornet-mps simulator backend Nov 15, 2023
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request no release notes Don't list this PR in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants