Skip to content

PythonUtils: more portable version of dirExists() - #792

Merged
devernay merged 1 commit into
RB-2.4from
RB-2.4-VisualStudio
May 16, 2022
Merged

devernay merged 1 commit into
RB-2.4from
RB-2.4-VisualStudio

Conversation

@devernay

Copy link
Copy Markdown
Member

fixes #790

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fix compilation of PythonUtils.cpp with Visual Studio, and implement a more portable version of dirExists()

Have you tested your changes (if applicable)? If so, how?

No, as I don't have Windows or VS

@devernay
devernay requested a review from rodlie May 16, 2022 18:01
@rodlie

rodlie commented May 16, 2022

Copy link
Copy Markdown
Contributor

MinGW build OK.

@devernay
devernay merged commit 1018b37 into RB-2.4 May 16, 2022
Niik-l pushed a commit to Niik-l/Natron that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants