Repository navigation
Partially revert Shiboken generation in QMake for Python bindings - #830
Merged
Merged
Conversation
5 tasks done
16 of 17 tasks
Member
|
Now you know why I wanted to keep the manual instructions :-) |
devernay
self-requested a review
July 23, 2022 19:28
devernay
approved these changes
Jul 23, 2022
Member
Author
Though it applies to the QMake case, but in my defense I'd say that QMake doesn't really have a clear way to detect where the bindings were placed. Though I want to apologize for the issues carried by that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
This PR reverts #803 partially due to the many issues introduced by it, but the install instructions, build configurations and generator cleanup scripts were conserved.
Show a few screenshots (if this is a visual change)
N/A.
Have you tested your changes (if applicable)? If so, how?
N/A yet.
Futher details of this pull request
The documentation will be updated to point users out to use the proper build system when using a Qt version.