Skip to content

Sentry fixes related to 4.0.0 release (openshot-qt) - #6111

Merged
jonoomph merged 7 commits into
developfrom
sentry-fix-2026-09-05
Sep 5, 2026
Merged

jonoomph merged 7 commits into
developfrom
sentry-fix-2026-09-05

Conversation

@jonoomph

@jonoomph jonoomph commented Sep 5, 2026 •

Copy link
Copy Markdown
Member

Misc fixes for Sentry related to OpenShot/libopenshot#1094

  • Include missing Wayland capture module in Linux packages.
  • Reject media opened as projects; allow .osp repair backups.
  • Handle locked Windows recordings safely.
  • Preserve fast recording moves with safe copy fallback.
  • Guard dock-tab mouse event handling.

Addresses OPENSHOT-FY6Z: include the unversioned capture module and inspect its dependencies while retaining host PipeWire exclusions.
Addresses OPENSHOT-FYN7 and OPENSHOT-FYA3: publish a complete copy before attempting source removal, tolerate sharing violations during cleanup, and test interrupted copies and reader path updates.
Addresses OPENSHOT-FYT6 and OPENSHOT-FYAA: reject local media paths before clearing project state and validate mouse event wrappers before reading button(). Preserve Android document URIs and case-insensitive project extensions.
This branch addresses five of the top 10 Sentry reports ranked by affected users for openshot@4.0.0, first seen on or after 2026-08-30. Together with libopenshot, this batch addresses seven reports. Earlier commits contain the core fixes; this commit completes review follow-ups and validation.

- FY6Z: Include the optional Wayland capture shared module and scan its dependencies in Linux packaging.
- FYT6: Reject media opened as projects before clearing project state; accept .osp and OpenShot repair backups (.osp.bak and numbered variants), case-insensitively, while preserving Android document URIs.
- FYN7: Retain Windows-locked runtime recordings when a complete project asset already exists and update reader paths.
- FYA3: Preserve fast same-filesystem recording renames; use atomic copy fallback for cross-filesystem moves or Windows sharing violations, tolerating only sharing violation 32 during source cleanup.
- FYAA: Require QMouseEvent before accessing button() in dock-tab mouse-release handling.
- Add regression coverage for backup names, misleading paths, no-copy recording moves, cross-device fallback, locked readers, and interrupted copies.
- Validation: 126 targeted Python tests pass; git diff --check passes.
- Keep FY5H, FYP5, and FYMJ outside this batch; retain documented Windows hardware and packaged Wayland validation requirements.
@jonoomph

jonoomph commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@jonoomph jonoomph changed the title Sentry fixes related to 4.0.0 release (libopenshot) Sentry fixes related to 4.0.0 release (openshot-qt) Sep 5, 2026
@jonoomph
jonoomph merged commit aa694c5 into develop Sep 5, 2026
8 checks passed
@jonoomph
jonoomph deleted the sentry-fix-2026-09-05 branch September 5, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant