Repository navigation
Fix Sentry errors and stabilize undo/redo, slicing, and project saves - #6125
Merged
Merged
Conversation
Address F3Z0, 69HH, GZ, DJWP, and FJMK with focused guards, safe SVG preview cleanup, and preservation of complete readers on clip insertion. Reject late partial updates for missing clips and fail saves before mutation when asset creation fails. Add eight regression tests covering failures and recovery, real Qt selection signals, native layout assignment, and SVG rendering. All eight fail against the prior source; all 591 Python tests pass with offscreen Qt.
Sentry fixes: - OPENSHOT-F3Z0: Handle preview titles before playback starts or after it stops. - OPENSHOT-69HH: Preserve the audio layout while export choices are refreshed. - OPENSHOT-GZ: Stop saving safely when the project asset folder cannot be created. - OPENSHOT-DJWP: Handle unreadable SVG titles and allow preview generation to retry. - OPENSHOT-FJMK: Ignore late partial edits to deleted clips and keep readers on new clips. Additional fixes: - Refresh native clip and effect references after edits to avoid using deleted objects. - Keep early native refreshes out of the project query cache, preventing overlapping slices and trimmed clips returning to their original length. - Let razor clicks cut through clip titles without opening a menu on mouse release. - Keep undo snapshots independent so later trims and effect edits cannot rewrite them. - Preserve title, recording, and other asset paths in undo/redo history across Save, Save As, and reopening, including recordings present only in undone actions. Validation: all 598 Python tests pass, including native/query/store integration, full insertion undo/redo, effect edits, repeated slicing, and save/history recovery. The paired libopenshot branch passes 518 native tests with two VAAPI hardware skips. Manual editing tests were reported stable by Jonathan. Final diffs pass whitespace checks and both branches include current origin/develop. This summary records the completed fixes in the preceding commits. Broad BV93 crash groups and FY5H are not fully resolved. Packaged Windows/macOS and real Windows/Wayland recording validation remain outstanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several OpenShot 4.0.0 Sentry reports and editing problems found during manual testing.
Sentry fixes:
Additional fixes:
Save As, and reopening, including recordings present only in undone actions.