Repository navigation
Fix global phase update in BasisTranslator Pass - #14078
Merged
Raynel Sanchez (raynelfss) merged 3 commits intoMar 25, 2025
Merged
Conversation
Alexander Ivrii (alexanderivrii)
requested a review
from a team
as a code owner
March 24, 2025 12:52
Collaborator
|
One or more of the following people are relevant to this code:
|
Alexander Ivrii (alexanderivrii)
added
the
Changelog: Fixed
Pull Request Test Coverage Report for Build 14036974943Details
💛 - Coveralls |
Raynel Sanchez (raynelfss)
approved these changes
Mar 25, 2025
Raynel Sanchez (raynelfss)
left a comment
Raynel Sanchez (raynelfss)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Happy merging 🚀
Raynel Sanchez (raynelfss)
added
the
stable backport potential
Contributor
|
Mergify (@Mergifyio) backport stable/1.4 stable/2.0 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* add missing branch for global phase update in basis_translator * Adding test * reno (cherry picked from commit d67c818) # Conflicts: # crates/accelerate/src/basis/basis_translator/mod.rs # test/python/transpiler/test_basis_translator.py
mergify Bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* add missing branch for global phase update in basis_translator * Adding test * reno (cherry picked from commit d67c818) # Conflicts: # crates/accelerate/src/basis/basis_translator/mod.rs
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
…14092) * Fix global phase update in `BasisTranslator` Pass (#14078) * add missing branch for global phase update in basis_translator * Adding test * reno (cherry picked from commit d67c818) # Conflicts: # crates/accelerate/src/basis/basis_translator/mod.rs * Fix: Add missing py token in `add_global_phase`. --------- Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> Co-authored-by: Raynel Sanchez <raynelfss@hotmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
…14091) * Fix global phase update in `BasisTranslator` Pass (#14078) * add missing branch for global phase update in basis_translator * Adding test * reno (cherry picked from commit d67c818) # Conflicts: # crates/accelerate/src/basis/basis_translator/mod.rs # test/python/transpiler/test_basis_translator.py * Fix: Add py token to `add_global_phase` * Update test_basis_translator.py * Fix: Use `new_bound` methods. --------- Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> Co-authored-by: Raynel Sanchez <raynelfss@hotmail.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>
Merged
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14074.
The
basis_translatorpass was not always updating the DAG's global phase as a part ofreplace_node: this was only done when the target dag's global phase matchedParam::ParameterExpression. Updating the global phase in the case ofParam::Floatwas missing, and this is fixed now.I am somewhat unsure if we also need to handle the
Param::Objcase. I don't understand in what kind of a circuit we would see this, and I don't believe it's even supported, as perdag_circuit.rs.add_global_phase, which throws an error in the case ofParam::Obj. Update: Jake Lishman (@jakelishman) confirmed thatParam::Objis never permitted inglobal_phase.Update: added release notes.