Repository navigation
Debugger/Qt: Non-blocking thread list refreshing - #16051
Merged
Merged
Conversation
Megamouse
reviewed
Sep 6, 2024
elad335
changed the title
elad335
force-pushed
the
debug
branch
3 times, most recently
from
September 6, 2024 16:26
3c0d4d4 to
c24c037
Compare
Contributor
|
Why the FAudio change? |
elad335
force-pushed
the
debug
branch
2 times, most recently
from
September 6, 2024 16:30
3d7409d to
454aca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use blocking-wait on IDM's mutex for the debugger as, in the case of emulation crash or simply long hold of IDM's mutex ownership, can cause the UI to deadlock.
Instead, if locking fails queue the thread-list refresh to next QT events workload.
This is also an optimization, moving thread refresh away from the constant update timer onto the moment you click on the thread-selector combo box.