Repository navigation
[Misc] Fix some Qt-related issues on macOS - #16120
Merged
Merged
Conversation
Apparently calling qt_finalize_target in the CMake list is needed for permissions-related stuff to work.
Needed for qtimageformats changes to kick in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes that are bundled into one PR, which fix a few Qt-related problems on macOS RPCS3 builds from my testing.
-Added a line to CMakeLists that apparently is needed to ensure Qt permission prompt handling works, fixing camera support on macOS.
-Made CI scripts for macOS also download the qtimageformats plugin, which is needed for successful icon creation when making Desktop/Launchpad shortcuts.
Should fix #14795 properly, partially deals with #16017 when it comes to shortcut icon creation failure only.