Skip to content

VS: Fix debug builds - #16170

Merged
Megamouse merged 4 commits into
RPCS3:masterfrom
Megamouse:debug
Oct 3, 2024
Merged

Megamouse merged 4 commits into
RPCS3:masterfrom
Megamouse:debug

Conversation

@Megamouse

@Megamouse Megamouse commented Oct 3, 2024 •

Copy link
Copy Markdown
Contributor
  • Adds some build files to the VS filters so I don't have to use different IDEs
  • Adds missing AdditionalDependencies to debug
  • Fix zstd debug output lib
  • Unify library directories by using ${Configuration}
  • Use opengl debug libs (maybe the names changed since last version update)
  • Remove unused SPIRV submodules

@Megamouse Megamouse added OS: Windows Build and CI Anything related to the build process and continuous integration labels Oct 3, 2024
@digant73

digant73 commented Oct 3, 2024 •

Copy link
Copy Markdown
Contributor

good. Is also cmake properly working? I needed to apply the following changes:

CMakePresets.json: Added OpenAL and Curl settings and set them to OFF on the msvc section:

      "cacheVariables": {
        "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}",
        "USE_FAUDIO": "OFF",
        "USE_PRECOMPILED_HEADERS": "ON",
        "USE_SYSTEM_ZLIB": "OFF",
        "USE_NATIVE_INSTRUCTIONS": "ON",
        "BUILD_LLVM": "ON",
        "STATIC_LINK_LLVM": "ON",
        "USE_SYSTEM_OPENAL": "OFF",
        "USE_SYSTEM_CURL": "OFF"
      },

3rdparty\llvm\CMakeLists.txt:

		if(WIN32 AND COMPILER_X86)
			set(LLVM_USE_INTEL_JITEVENTS ON)
		endif()

replaced with (otherwise we will get a link error on missing LLVMIntelJITEvents.lib):

		# For non arm64 windows
		if(WIN32 AND (COMPILER_X86 OR (MSVC AND NOT COMPILER_ARM)))
			set(LLVM_USE_INTEL_JITEVENTS ON)
		endif()

CMAKE_PREFIX_PATH: env variable set to same path as in QTDIR env variable (otherwise we will get link error on QT libs

as discussed with @oltoln in #16161.
You could also mark #16161 as fixed by your PR.

If you could provide those changes on your PR it should be better. Possibly make changes on cmake files so it is not required to define CMAKE_PREFIX_PATH but use the existing QTDIR env variable.

@Megamouse

Copy link
Copy Markdown
Contributor Author

How am I supposed to know. No-one uses cmake on windows

@Megamouse

Copy link
Copy Markdown
Contributor Author

It's an open source project. Feel free to open a PR

@digant73

digant73 commented Oct 3, 2024 •

Copy link
Copy Markdown
Contributor

How am I supposed to know. No-one uses cmake on windows

I used cmake because Debug mode on sln project was not working (compilation failed)

@Megamouse
Megamouse merged commit 6bb0106 into RPCS3:master Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build and CI Anything related to the build process and continuous integration OS: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants