Repository navigation
3rd Party: Bump MoltenVK to 1.2.11 (Vulkan SDK 1.3.296) - #16190
Merged
Merged
Conversation
Contributor
Author
|
The build failure is unrelated to this PR. Merging should be held until the issue is fixed and this PR can be properly tested. |
Contributor
Author
|
Both x86 and Arm CI builds are working. Should be ok to merge. Closes #16179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
Changelog for 1.2.11:
MVKConfiguration::preallocateDescriptorsandMVK_CONFIG_PREALLOCATE_DESCRIPTORSenvironment variable.vkAllocateDescriptorSets(): Per Vulkan spec, if any descriptor set allocation fails, populate all descriptor set pointers with VK_NULL_HANDLE. In addition, returnVK_ERROR_FRAGMENTED_POOLif failure was due to pool fragmentation.vkUpdateDescriptorSets(): Per Vulkan spec, allow write or copy beyond the end of a descriptor binding count, including inline uniform block descriptors.VkFormatcapabilities based on latest Metal docs.VK_EXT_layer_settingsis used.VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BITandVK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BITfor storage texel buffers.vkUpdateDescriptorSets(): Support writing beyond descriptor binding size if subsequent bindings are of same type.vkCmdPushDescriptorSetWithTemplateKHR()when entries inVkDescriptorUpdateTemplateCreateInfoare not sorted by offset.vkQueueWaitIdle()andvkDeviceWaitIdle()were not waiting for all commands to be enqueued before enqueuing wait operation.vkAllocateDescriptorSets().VkDescriptorSetLayoutis destroyed while descriptor set is in use.VK_FORMAT_A2B10G10R10_UNORM_PACK32andVK_FORMAT_A2R10G10B10_UNORM_PACK32formats as surface formats on all platforms.MTLStoreActionmapping forVK_ATTACHMENT_STORE_OP_NONE.vkGetPastPresentationTimingGOOGLE().minSubgroupSizeon AMD RX6600 to32.VK_GOOGLE_display_timinginfo is available during presentation.MVKConfiguration::shaderLogEstimatedGLSL, and environment variableMVK_CONFIG_SHADER_LOG_ESTIMATED_GLSL, to enable or disable the logging of estimated GLSL code, and disable it by default--is missing on platform names.MVK_PRIVATE_API_VERSIONto version43.