Repository navigation
RSX: Use AVX-512-ICL in vertex shader hashing and comparisons - #16780
Merged
Merged
Conversation
Member
Author
Xcedf
pushed a commit
to Xcedf/rpcs3
that referenced
this pull request
Feb 28, 2025
Contributor
kd-11
reviewed
Mar 1, 2025
kd-11
reviewed
Mar 1, 2025
kd-11
reviewed
Mar 1, 2025
kd-11
left a comment
Contributor
There was a problem hiding this comment.
I can't prove or disprove the correctness of the avx512 stuff without an avx512 cpu and we have no unit tests, so I guess just yolo and bulk-revert if a regression occurs.
…rtex_program_compare - Code is about 4 times as fast on my zen4 machine - Should be twice as fast on zen5 machines with full width AVX-512
Contributor
|
@cipherxof Can you disable locally this pr and apply #16797 and test it? it applies a similar improvement to non-avx512 users as well. |
Xcedf
pushed a commit
to Xcedf/rpcs3
that referenced
this pull request
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







This code uses vpermt2b, and needs full length AVX-512 to function, so this won't work for skylake-x nor avx10-256.
Before: (194 avg)


After: (204 avg)
Before:


After: