Skip to content

rsx: Minor improvements - #17040

Merged
kd-11 merged 2 commits into
RPCS3:masterfrom
kd-11:rsx-volatile
Apr 14, 2025
Merged

kd-11 merged 2 commits into
RPCS3:masterfrom
kd-11:rsx-volatile

Conversation

@kd-11

@kd-11 kd-11 commented Apr 13, 2025 •

Copy link
Copy Markdown
Contributor
  1. Fix simple_array::erase_if. Not used much but fixes a broken optimization check in the texture cache when performing blit operations.
  2. Make instancing data preparation less punishing by reusing scratch buffers

@kd-11 kd-11 changed the title rsx: Fix simple_array<T>::erase_if rsx: Minor improvements Apr 13, 2025
@Megamouse Megamouse added the RSX label Apr 13, 2025
@kd-11
kd-11 merged commit 7500d16 into RPCS3:master Apr 14, 2025
@digant73

Copy link
Copy Markdown
Contributor

is it possible that regression #17043 is due to a missing instancing_indirection_table.clear() after line 761 in RSXDrawCommands.cpp?

@kd-11

kd-11 commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

is it possible that regression #17043 is due to a missing instancing_indirection_table.clear() after line 761 in RSXDrawCommands.cpp?

No. The buffer size is explicitly set. It's just an array, so clearing doesn't do anything to the contents.

@digant73

Copy link
Copy Markdown
Contributor

is it possible that regression #17043 is due to a missing instancing_indirection_table.clear() after line 761 in RSXDrawCommands.cpp?

No. The buffer size is explicitly set. It's just an array, so clearing doesn't do anything to the contents.

yes. My doubt was that the data not affected by the .resize() method were not re-initialized. But I saw later that the array is fully initialized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants