Skip to content

Disable -Wold-style-cast diagnostic before including sse2neon - #17316

Merged
Megamouse merged 1 commit into
RPCS3:masterfrom
marcin-serwin:push-qxrtpxvnqlot
Jun 18, 2025
Merged

Megamouse merged 1 commit into
RPCS3:masterfrom
marcin-serwin:push-qxrtpxvnqlot

Conversation

@marcin-serwin

@marcin-serwin marcin-serwin commented Jun 17, 2025 •

Copy link
Copy Markdown
Contributor

Building with gcc on aarch64-linux fails otherwise.

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@AniLeo
AniLeo requested a review from kd-11 June 18, 2025 08:03
@kd-11

kd-11 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

QQ - Then why was linux-arm64 CI not failing if this is a problem?
e.g latest run -> https://github.com/RPCS3/rpcs3/actions/runs/15674041842/job/44150272330

@marcin-serwin

marcin-serwin commented Jun 18, 2025 via email

Copy link
Copy Markdown
Contributor Author

@Megamouse

Copy link
Copy Markdown
Contributor

QQ - Then why was linux-arm64 CI not failing if this is a problem? e.g latest run ->
the sse2neon header uses this:

#if defined(__clang__) && defined(ARCH_ARM64)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wold-style-cast"
#endif

@kd-11

kd-11 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

QQ - Then why was linux-arm64 CI not failing if this is a problem?
The linux-arm64 CI is using clang, not gcc. Perhaps a gcc workflow should also be added to match the x86 ones which test both compilers?

Yes, this is a good point. We usually have both gcc and clang.

@Megamouse
Megamouse merged commit bad6e99 into RPCS3:master Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants