Repository navigation
Update OpenAL-soft submodule - #17552
Merged
Merged
Conversation
Contributor
|
We don't update unless there's a version tag |
Contributor
Author
The most recent version tag is outdated, due to the changes in FMT. Open Issue: kcat/openal-soft#1187 |
Contributor
|
We could temprarily fork the used version and add the commit, depends on how far off the version tag is. |
5 of 6 tasks
Megamouse
added
the
Build and CI
Member
|
We should just make an exception and jump to the untagged commit, as this PR unbreaks the Clang build. Whenever the version is tagged, we update to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OpenAL-soft module to kcat/openal-soft@0e5e98e or newer.
Contains fixes for fmtlib/fmt#4520 when building with FMT 11.
Part 1 of 3 fixes for Msys2 clang build
Edit: Other 2 fixes have been merged.