Skip to content

Add an entry on Log panel's contextual menu to show the main disk usa… - #17715

Merged
elad335 merged 6 commits into
RPCS3:masterfrom
digant73:disk_usage
Nov 26, 2025
Merged

elad335 merged 6 commits into
RPCS3:masterfrom
digant73:disk_usage

Conversation

@digant73

@digant73 digant73 commented Nov 19, 2025 •

Copy link
Copy Markdown
Contributor

Added the entry Show Disk Usage on Log panel's contextual menu to show the main disk usage of the emulator.
It reports VFS disk usage (with the exception of useless usb directories) and cache disk usage.
I avoided to automatically display the disk usage, e.g. when refreshing the game list, just because the disk usage calculation can require some time (so it will slow down the emulator). So I opted to provide the functionality on demand.
This PR is propaedeutic to #6008. A separated PR to complete #6008 will follow. It will allow multiple selection of games on game list and a contextual menu to manage the removal of the selected games.

Related to #6008



Log panel's contextual menu:

image

Main disk usage on dialog box and Log panel:

image

image

@elad335

elad335 commented Nov 19, 2025 •

Copy link
Copy Markdown
Contributor

Computing directory size is a heavy task. Especially for network drives. Furthermore users don't typically read the logs unless their games froze or crashed. Logs are developer-oriented.

Edit: NVM, I see that it is done on user request only.

Comment thread rpcs3/rpcs3qt/log_frame.cpp Outdated
@digant73

digant73 commented Nov 19, 2025 •

Copy link
Copy Markdown
Contributor Author

Computing directory size is a heavy task. Especially for network drives. Furthermore users don't typically read the logs unless their games froze or crashed. Logs are developer-oriented.

Edit: NVM, I see that it is done on user request only.

Yes. I saw it can take some time even on a m2 (2 seconds on my hw to scan 180 GB on dev_hdd0 with many files). So I opted for an on demand feature. I avoided to provide a dialog box or a button on main menus or tools bar. It seems to me enough to provide that feature on Log panel only with a minimum effort. It's just a stat displayed

Comment thread rpcs3/rpcs3qt/log_frame.cpp
@digant73

Copy link
Copy Markdown
Contributor Author

@Megamouse is there still something blocking the merge?

@elad335

elad335 commented Nov 26, 2025 •

Copy link
Copy Markdown
Contributor

@digant73 Mac builds are failing with a code error. Resolved by #17755

@elad335

elad335 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

Now it's a different error xD

Comment thread rpcs3/rpcs3qt/log_frame.cpp Outdated
Co-authored-by: Megamouse <studienricky89@googlemail.com>
@elad335
elad335 merged commit 6ebdb0c into RPCS3:master Nov 26, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants