Repository navigation
RPCS3: Notify RAM shortage, Log current and peak RAM usage - #18103
Merged
Merged
Conversation
AniLeo
reviewed
Jan 24, 2026
| return { status.ullTotalPhys, status.ullAvailPhys }; | ||
|
|
||
| #else | ||
| // TODO |
Member
There was a problem hiding this comment.
Missing other OS implementations, just to keep in mind
elad335
marked this pull request as ready for review
March 27, 2026 16:15
elad335
enabled auto-merge (rebase)
March 27, 2026 16:30
elad335
disabled auto-merge
March 27, 2026 16:41
13xforever
reviewed
Mar 28, 2026
|
|
||
| if (elapsed_us >= log_interval_us) | ||
| const u64 current_mem_use = utils::get_memory_usage().second; | ||
| const u64 mem_use_increase = current_mem_use >= max_memory_usage ? current_mem_use - max_memory_usage : 0; |
Contributor
There was a problem hiding this comment.
Why >= instead of >? You're just doing an extra subtraction to get 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Spider-Man crashes a few minutes into gameplay with ERROR_NO_SYSTEM_RESOURCES (#18040) #18094
RAM stats are currently Windows-only until implementation and testing is done on other platforms.