Repository navigation
Fix generic_async_transaction_context thread handling - #18129
Merged
Merged
Conversation
RipleyTom
force-pushed
the
fix_score_thread
branch
from
January 31, 2026 05:32
abace4d to
20563e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the thread itself was the last holder of the generic_async_transaction_context, when it dropped it, the thread tried to join itself and it resulted in a possible crash.
Interestingly the behaviour was different on Linux and Windows. On Linux this causes a SIGSEGV and termination. On Windows this just hanged the thread.
I've added a commit to force disable IPv6 support, I've changed the name of the config, set it to false by default and commented out the UI part. There are too many issues for now to have it enabled by default like it was.