Skip to content

Make performance overlays use window space - #18419

Merged
Megamouse merged 11 commits into
RPCS3:masterfrom
BehroozRezvani:feature/perf-overlay-window-space
Mar 27, 2026
Merged

Megamouse merged 11 commits into
RPCS3:masterfrom
BehroozRezvani:feature/perf-overlay-window-space

Conversation

@BehroozRezvani

Copy link
Copy Markdown
Contributor

Adds a new performance overlay option to use the whole window as rather than just framebuffer space.
Can not be placed outside of the game in non-16:9 aspect ratio displays (e.g. 21:9)

@BehroozRezvani
BehroozRezvani marked this pull request as draft March 21, 2026 16:11
@BehroozRezvani
BehroozRezvani marked this pull request as ready for review March 21, 2026 16:15
@AniLeo
AniLeo requested a review from kd-11 March 21, 2026 16:17
@BehroozRezvani

Copy link
Copy Markdown
Contributor Author

Hi maintainers, this is my first PR to RPCS3, so let me know if there is any issue or guideline inconsistencies

Comment thread rpcs3/rpcs3qt/emu_settings_type.h Outdated
Comment thread rpcs3/Emu/system_config.h Outdated
Comment thread rpcs3/Emu/system_config.h Outdated
@BehroozRezvani

Copy link
Copy Markdown
Contributor Author
Screenshot_20260321_190009 Screenshot_20260321_190052

Comment thread rpcs3/Emu/RSX/Overlays/overlay_perf_metrics.cpp
Comment thread rpcs3/Emu/system_config.h Outdated
Comment thread rpcs3/Emu/RSX/Overlays/overlay_perf_metrics.cpp Outdated
Comment thread rpcs3/Emu/RSX/Overlays/overlays.h
Comment thread rpcs3/Emu/RSX/Overlays/overlays.h Outdated
Comment thread rpcs3/Emu/RSX/Overlays/overlays.h Outdated
Comment thread rpcs3/rpcs3qt/tooltips.h Outdated
Comment thread rpcs3/rpcs3qt/tooltips.h Outdated
@BehroozRezvani

Copy link
Copy Markdown
Contributor Author

I was testing and experimenting, should I just take out the option to switch between the two path of showing the perf overlay?
Since the implementation of using "window space" is adaptive to any aspect ratio, and would simplify the implementation.
@kd-11 @Megamouse

Will address the comments soon as well

@kd-11

kd-11 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

I was testing and experimenting, should I just take out the option to switch between the two path of showing the perf overlay? Since the implementation of using "window space" is adaptive to any aspect ratio, and would simplify the implementation. @kd-11 @Megamouse

Will address the comments soon as well

Definitely not. That would make things harder for example when providing recordings for evidence of performance dips without having to fiddle with the settings. It also makes it really annoying for promo videos since there are existing rules/templates to make the performance overlays align on clips from completely different users with different monitors - you get the idea. While I personally like and will make use of the window-space feature it is not a one-size-fits-all in any way.

@BehroozRezvani
BehroozRezvani force-pushed the feature/perf-overlay-window-space branch from fccddda to 31e561e Compare March 25, 2026 00:50
@kd-11

kd-11 commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

@BehroozRezvani Please rebase and force-push. Github UI is complaining about merge conflicts which I don't see.

@BehroozRezvani

Copy link
Copy Markdown
Contributor Author

Seems to have passed all checks, waiting on @Megamouse approval I believe

@Megamouse
Megamouse merged commit 2702417 into RPCS3:master Mar 27, 2026
10 checks passed
@BehroozRezvani
BehroozRezvani deleted the feature/perf-overlay-window-space branch March 27, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants