Repository navigation
Fix PS1 classics shortcuts - #19012
Merged
Merged
Conversation
Megamouse
force-pushed
the
sadasadssd
branch
2 times, most recently
from
July 9, 2026 17:32
0bc35a8 to
5c140b0
Compare
elad335
reviewed
Jul 9, 2026
elad335
approved these changes
Jul 9, 2026
elad335
left a comment
elad335
left a comment
Contributor
There was a problem hiding this comment.
This functionality was not designed properly in the first place, but for the scope of the bugfix it is good. I'll redesign it later.
Megamouse
commented
Jul 9, 2026
| if (!test_path.empty() && fs::is_file(test_path)) | ||
| // Check for regular binaries as well as PS1 binaries | ||
| for (const std::string& bin_suffix : {"EBOOT.BIN", "ISO.BIN.EDAT"}) | ||
| { |
Contributor
Author
There was a problem hiding this comment.
I think this will produce a warning. Let me check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix shortcut creation and path resolve of PS1 classics.
Fixes #19011