Skip to content

Fix pkg installation - #19278

Merged
Megamouse merged 2 commits into
RPCS3:masterfrom
Megamouse:pkg_fixus
Aug 19, 2026
Merged

Megamouse merged 2 commits into
RPCS3:masterfrom
Megamouse:pkg_fixus

Conversation

@Megamouse

Copy link
Copy Markdown
Contributor
  • Fix pkg installation buffer size checks. Only use the local buffer size if it's actually the output of the read.
  • Fix missing pkg install error if any thread throws an exception. It was just logging a fatal error and then installed the rest of the data.
  • Only use the thread group if we actually install with more than one thread

I didn't realize the pkg_file_reader struct was also passed to the EDATADecrypter,
since the packages I used for testing didn't go into that path.

fixes #19277

@Megamouse
Megamouse marked this pull request as ready for review August 19, 2026 20:41
@Megamouse
Megamouse force-pushed the pkg_fixus branch 2 times, most recently from 178ef40 to 0934bea Compare August 19, 2026 20:46
@digant73

Copy link
Copy Markdown
Contributor

@Megamouse see #19279 for other possible issues (padding/alignment) that could be fixed. One of it is pre-build 0.0.42-19785

@Megamouse
Megamouse merged commit c122edd into RPCS3:master Aug 19, 2026
9 of 10 checks passed
@Megamouse
Megamouse deleted the pkg_fixus branch August 19, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression] Portal 2 - No Longer Installs to HDD Correctly (#19169)

2 participants