Repository navigation
Various emulation bugfixes - #19282
Merged
Merged
Conversation
Megamouse
reviewed
Aug 20, 2026
Megamouse
reviewed
Aug 20, 2026
elad335
reviewed
Aug 20, 2026
elad335
enabled auto-merge (rebase)
August 21, 2026 07:21
elad335
disabled auto-merge
August 21, 2026 07:27
elad335
reviewed
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of note is the change in get_mp, before paths would never work as get_path_root_and_trail does not return the leading "/"(I changed the function description to reflect this as it implied it did) and paths are compared against the paths with leading slashes(ie /dev_hdd0, etc). I wouldn't mind some double checking on this and on the side effects of allowing it now.